Change order of lines to properly raise events #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you mean not tested? And why does the lines changing order fix it? |
|
I mean that I did not check if the entire game remains sane. Changing the order of these lines indeed helped resolve the issue due to the ordering of the value adjustment. |
|
This is a hard logic scenario to assess. |
|
@smoogipoo requesting your review on this as I modified the behaviour and added considerably. |
peppy
previously approved these changes
May 9, 2018
smoogipoo
previously requested changes
May 9, 2018
| @@ -164,14 +164,20 @@ public virtual void TriggerChange() | |||
|
|
|||
| protected void TriggerValueChange(bool propagateToBindings = true) | |||
| { | |||
| ValueChanged?.Invoke(value); | |||
| // check a bound bindable hasn't changed the value again (it will fire its own event) | |||
| T beforePropagation = Value; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
approved these changes
May 9, 2018
peppy
added a commit
to peppy/osu-framework
that referenced
this pull request
May 10, 2018
smoogipoo
added a commit
that referenced
this pull request
May 10, 2018
Commit missed change from #1545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2460 and every other future similar implementation's issues with resetting values.
This is not really tested, but it should (hopefully) not break anything.